Rewrote SprigganFXSCRIPT

source/scripts/sprigganfxscript.psc

@@ -1,121 +1,144 @@
 Scriptname SprigganFXSCRIPT extends ActiveMagicEffect  
 {Attaches and controlss spriggan FX}
 
-import utility
+; Eddoursul 2024.01.27: Multi-stage dying, fixed the KillFX Papyrus warning
-import form
 
-Actor selfRef
 VisualEffect Property SprigganFXAttachEffect Auto
 Spell Property crSprigganHeal01 Auto
 Spell Property crSprigganCallCreatures Auto
 Idle Property FFselfIdle  Auto  
-int doOnce
+bool bBledout
+bool bIsDead
 ;===============================================
 
-;RegisterForSleep() ; Before we can use OnSleepStart we must register.
+auto state Alive
- 
 
 	EVENT OnEffectStart(Actor Target, Actor Caster)
-		;Play your particles.
+		if Target == None
-		selfRef = caster		
-
-		;Added by USKP to prevent this effect from appearing on the player.
-		If selfRef == Game.GetPlayer()
-			Dispel()
-			return
-		EndIf
-
-		;USKP 2.0 - Check for NONE and spit an error out to see if we can find it
-		if( selfRef == None )
-			Debug.TraceStack( "USKP error check: Spriggan called this as a NONE. Please report this error to the USKP team." )
 			Return
 		EndIf
 		
-		;USSEP 4.1.5 Bug #14445: added this line:
+		If Target.IsDead() || Target == Game.GetForm(0x14)
-		RegisterForAnimationEvent (selfRef, "KillFX")
+			GotoState("DoNothing")
-		RegisterForAnimationEvent (selfRef, "Revive")
+			Dispel()
+			return
+		EndIf
 		
-		;test to see if spriggan is in ambush mode
+		;test to see if spriggan is not in ambush mode
-		if (selfRef.GetSleepState() == 3)
+		if (Target.IsInCombat() || Target.GetSleepState() == 0) && Target.Is3DLoaded()
-; 			Debug.Trace("Spriggan is sleeping! 3")
+			SprigganFXAttachEffect.Play(Target, -1)
-			selfRef.PlaySubGraphAnimation( "KillFX" )
+		endif
-		else
-			;USKP 2.0.3 - 3D check needed before shaders.
-			if( selfRef.Is3DLoaded() )
-				SprigganFXAttachEffect.Play(selfRef, -1)
-			EndIf
-		endIf
 	ENDEVENT
 
+	; May fire when dispelled with a script or console
 	Event OnEffectFinish(Actor akTarget, Actor akCaster)
-		SprigganFXAttachEffect.Stop(selfRef)
+		GotoState("DoNothing")
+		SprigganFXAttachEffect.Stop(akTarget)
 	endEvent
 	
-	Event OnGetUp(ObjectReference akFurniture)
-		;Added by USKP to prevent this effect from appearing on the player.
-		If selfRef == Game.GetPlayer()
-			Dispel()
-			return
-		EndIf
-		
-		;USKP 2.0 - Check for NONE and spit an error out to see if we can find it
-		if( selfRef == None )
-			Debug.TraceStack( "USKP error check: Spriggan called this as a NONE. Please report this error to the USKP team." )
-			Return
-		EndIf
-		
-; 		Debug.Trace("We just got up from " )
-		SprigganFXAttachEffect.Play(selfRef, -1)
-		selfRef.PlaySubGraphAnimation( "Revive" )
-	endEvent
-	
-	EVENT onDeath(actor myKiller)
-		;(selfRef as actor).PlaySubGraphAnimation( "LeavesScared" )
-		;wait(10.0)
-		
-		;USKP 2.0 - Check for NONE and spit an error out to see if we can find it
-		if( selfRef == None )
-			Debug.TraceStack( "USKP error check: Spriggan called this as a NONE. Please report this error to the USKP team." )
-			Return
-		EndIf
-		selfRef.PlaySubGraphAnimation( "KillFX" )
-		wait(10.0)
-		SprigganFXAttachEffect.Stop(selfRef)	
-	ENDEVENT
-	
 	EVENT onCombatStateChanged(Actor akTarget, int aeCombatState)
+		Actor actorRef = GetTargetActor()
+	
+		if ! actorRef || ! actorRef.Is3DLoaded()
+			return
+		endif
+
+		if aeCombatState == 0
+			if actorRef.IsDead()
+				GotoState("Dying")
+				return
+			endif
+			SprigganFXAttachEffect.Stop(actorRef)
+			return
+		endif
+		
 		if aeCombatState == 1
-			selfRef.playIdle(FFselfIdle)
+			SprigganFXAttachEffect.Play(actorRef, -1)
-			utility.wait(3.0)
+			actorRef.playIdle(FFselfIdle)
-			
+			Utility.Wait(Utility.RandomFloat(1.0, 4.0))
-			;USKP 2.0.1 - If the 3D isn't loaded, don't cast.
+			crSprigganCallCreatures.cast(actorRef, actorRef)
-			if( selfRef.Is3DLoaded() )
-				crSprigganCallCreatures.cast(selfRef,selfRef)
-			EndIf
 		endif
 	endEVENT
+
+	Event OnGetUp(ObjectReference akFurniture)
+		Actor actorRef = GetTargetActor()
 	
-	Event OnEnterBleedout()
+		if ! actorRef
-; 		Debug.Trace("dude im bleeeding out" )
+			return
-		if doOnce == 0
+		endif
-			selfRef.PlaySubGraphAnimation( "KillFX" )
+		
-			wait(2.0)
+		SprigganFXAttachEffect.Play(actorRef, -1)
-			;USKP 2.0.1 - If the 3D isn't loaded, don't case.
+		actorRef.PlaySubGraphAnimation("Revive")
-			if( selfRef.Is3DLoaded() )
+	endEvent
-				crSprigganHeal01.Cast(selfRef)
+
-			EndIf
+	EVENT onDying(actor myKiller)
-			selfRef.setActorValue("variable07",1)
+		GotoState("Dying")
-			selfRef.evaluatePackage()
-			wait(1.0)		
-			selfRef.PlaySubGraphAnimation( "Revive" )
-			doOnce = 1
-		endIf
 	ENDEVENT
 
-;-----------------------------------------------------------------
+	EVENT onDeath(actor myKiller)
-;	Added by USSEP 4.1.5 for Bug #14445:
+		GotoState("Dying")
-;-----------------------------------------------------------------
+	endevent
 
-Event OnAnimationEvent (ObjectReference akSource, string asEventName)
+	Event OnEnterBleedout()
-	;do nothing
+		if bBledout
-EndEvent
+			return
+		endif
+		bBledout = true
+		RegisterForSingleUpdate(2.0)
+	ENDEVENT
+	
+	; Heals itself
+	event OnUpdate()
+		Actor actorRef = GetTargetActor()
+	
+		if ! actorRef
+			return
+		endif
+		
+		if actorRef.Is3DLoaded()
+			crSprigganHeal01.Cast(actorRef)
+			actorRef.setActorValue("variable07",1)
+			Utility.Wait(Utility.RandomFloat(1.5, 2.5))
+			actorRef.evaluatePackage()
+		endif
+	endevent
+
+endstate
+
+state Dying
+	event OnBeginState()
+		RegisterForSingleUpdate(Utility.RandomFloat(2.5, 4.5))
+	endevent
+
+	Event OnEffectFinish(Actor akTarget, Actor akCaster)
+		GotoState("DoNothing")
+		akTarget.PlaySubGraphAnimation("KillFX")
+	endEvent
+	
+	event OnCellAttach()
+		RegisterForSingleUpdate(1.0)
+	endevent
+	
+	event OnUpdate()
+		if bIsDead
+			Dispel()
+			return
+		endif
+		
+		bIsDead = true	
+		Actor actorRef = GetTargetActor()
+	
+		if actorRef
+			SprigganFXAttachEffect.Stop(actorRef)
+		endif
+		
+		RegisterForSingleUpdate(Utility.RandomFloat(3.0, 7.5))
+	endevent
+endstate
+
+state DoNothing
+endstate
+
+; Compiler wants it here
+Event OnEnterBleedout()
+ENDEVENT